Fix notebook vm lintingerror 2591448#25567
Closed
ragovada wants to merge 172 commits intoAzure:release-machinelearningservices-Microsoft.MachineLearningServices-2023-10-01from
Closed
Fix notebook vm lintingerror 2591448#25567ragovada wants to merge 172 commits intoAzure:release-machinelearningservices-Microsoft.MachineLearningServices-2023-10-01from
ragovada wants to merge 172 commits intoAzure:release-machinelearningservices-Microsoft.MachineLearningServices-2023-10-01from
Conversation
* sql readme.go.md directive * rename to ServerPrivateEndpointConnectionProperties * lenient-model-deduplication
* Update readme.python.md * Update readme.python.md
…e#24482) * Add beta2 api spec * add readme * fix lines * Fix readme * Added repeatability * Fix 202 long running * Fix header * Fix the base * Fix check * added x-ms-long-running-operation * add location * fix example * test * test * test * fix * test * fix test * test * Fix * test * test * fix * Remove LRO * Updates as per ARB feedback * Updates as per ARB feedback * Fix senddtmfTones * Fix error * Fix send dtmf description
…ll specs on selected files (Azure#25010) - Fixes Azure#25006
* Update readme.python.md * Update readme.python.md
…23-05-01-preview (Azure#25014) * Documentation fixes * Documentation fixes 2 * Documentation fixes 3 * Documentation fixes 4 * Documentation fixes 5 --------- Co-authored-by: Oren Kafka <orkafka@microsoft.com>
Azure#24837) * [ACS Chat] [Rest API] Added chat thread metadata and participant metadata. (Azure#24243) * Updating ACS Chat swagger with Chat thread and participant metadata. * Fixed swagger version. * Fixed swagger version. * Re-added data retention policy to the swagger. * Update communicationserviceschat.json - changed metadata from string to dictionary * Update communicationserviceschat.json * Update communicationserviceschat.json Corrected size limitations - should be 1k, not 2k * Update communicationserviceschat.json Added metadata to patch thread request * Update communicationserviceschat.json --------- Co-authored-by: Andrei Giurgiu <agiurg@microsoft.com> * remove data retention from 2023-07-01 --------- Co-authored-by: Andrei Giurgiu <agiurg@microsoft.com> Co-authored-by: Lu Chen <luc@microsoft.com>
* sql readme.go.md directive * fix
* Disable creation of perimeter base rule * Made NSP rule readonly * Added email/sms rule changes * Minor fix
…add version preview/2023-06-02-preview (Azure#24922) * Adds base for updating Microsoft.ContainerService/aks from version preview/2023-05-02-preview to version 2023-06-02-preview * Updates readme * Updates API version in new specs and examples * Hobov2 Change Swagger Preview (Azure#24472) * Hobov2 Swagger * fix error * Add SSHAccess property to agent pool (Azure#24460) * Add SSHAccess property to agent pool * add new line * Update specification/containerservice/resource-manager/Microsoft.ContainerService/aks/preview/2023-06-02-preview/managedClusters.json Co-authored-by: FumingZhang <81607949+FumingZhang@users.noreply.github.com> --------- Co-authored-by: FumingZhang <81607949+FumingZhang@users.noreply.github.com> * update python & java readmes (Azure#24461) * Image Integrity swagger in 20203-06-02-preview (Azure#24454) * Image Integrity swagger in 20203-060-20-preview * f * f * ff --------- Co-authored-by: fseldow <fseldow@V-BRMCCA-MOBILE.redmond.corp.microsoft.com> * Azure Service Mesh - BYO CA, Egress Gateway and Mesh Revisions (Azure#24453) * Azure Service Mesh - BYO CA and Egress Gateway * prettier fix. * adding changes for for revisions and meshversioncompatibilityprofile * adding a missing parameter * Changes as per lint failures * Mikolaj/add custom node config 2023 06 02 preview (Azure#24539) * feat: add Ulimit config and updated sysctl ranges to swagger * fix: use ulimits in json of LinuxOSConfig * feat: add response example * fix: add ulimits to custom words * Revert "fix: add ulimits to custom words" This reverts commit 9496737. --------- Co-authored-by: Mikolaj Umanski <mumanski@microsoft.com> * add Drain Timeout in preview (Azure#24579) Co-authored-by: Wenjun Gao <wenjungao@microsoft.com> * fix: remove ulimits from swagger spec (Azure#24921) Co-authored-by: Mikolaj Umanski <mumanski@microsoft.com> * address ARM review comments (Azure#25005) * address ARM review comments * added a missing description. * Update specification/containerservice/resource-manager/Microsoft.ContainerService/aks/preview/2023-06-02-preview/managedClusters.json Co-authored-by: Sanya Kochhar <42152676+SanyaKochhar@users.noreply.github.com> * Update specification/containerservice/resource-manager/Microsoft.ContainerService/aks/preview/2023-06-02-preview/managedClusters.json Co-authored-by: Sanya Kochhar <42152676+SanyaKochhar@users.noreply.github.com> * Update specification/containerservice/resource-manager/Microsoft.ContainerService/aks/preview/2023-06-02-preview/managedClusters.json Co-authored-by: Sanya Kochhar <42152676+SanyaKochhar@users.noreply.github.com> * Update specification/containerservice/resource-manager/Microsoft.ContainerService/aks/preview/2023-06-02-preview/managedClusters.json Co-authored-by: Sanya Kochhar <42152676+SanyaKochhar@users.noreply.github.com> * Update specification/containerservice/resource-manager/Microsoft.ContainerService/aks/preview/2023-06-02-preview/managedClusters.json Co-authored-by: Sanya Kochhar <42152676+SanyaKochhar@users.noreply.github.com> * Update specification/containerservice/resource-manager/Microsoft.ContainerService/aks/preview/2023-06-02-preview/managedClusters.json Co-authored-by: Sanya Kochhar <42152676+SanyaKochhar@users.noreply.github.com> --------- Co-authored-by: Sanya Kochhar <42152676+SanyaKochhar@users.noreply.github.com> --------- Co-authored-by: Xu Xue <55420084+xuexu6666@users.noreply.github.com> Co-authored-by: Tongyao Si <tosi@microsoft.com> Co-authored-by: Xinhe Li <xinhl@microsoft.com> Co-authored-by: fseldow <fseldow@V-BRMCCA-MOBILE.redmond.corp.microsoft.com> Co-authored-by: deveshdama <87668846+deveshdama@users.noreply.github.com> Co-authored-by: Mikołaj Umański <mik.umanski@gmail.com> Co-authored-by: Mikolaj Umanski <mumanski@microsoft.com> Co-authored-by: Wenjun Gao <wenjungaoat@gmail.com> Co-authored-by: Wenjun Gao <wenjungao@microsoft.com> Co-authored-by: Sanya Kochhar <42152676+SanyaKochhar@users.noreply.github.com>
…re#24939) * Adds base for updating Microsoft.App from version preview/2023-04-01-preview to version 2023-05-01 * Updates readme * Updates API version in new specs and examples
… version preview/2023-06-01-preview (Azure#24426) * Adds base for updating Microsoft.ContainerRegistry from version preview/2023-01-01-preview to version 2023-06-01-preview * Updates readme * Updates API version in new specs and examples * Added new api version 2023-06-01-preview * Fixed examples * Fixed Prettier check. * Fix lint error. * fix pretty print * Try fix avacodo error * Fix the default tag * add directive in readme.go.md --------- Co-authored-by: Alancere <804873052@qq.com>
…crosoft.Kusto-2023-05-02' (Azure#24964) * kusto 2023-05-02 fix "final-state-via" header * take 2 * remove "x-ms-long-running-operation-options" * remove "x-ms-long-running-operation-options"
* Adds base for updating Microsoft.SecurityInsights from version preview/2023-06-01-preview to version 2023-07-01-preview * Updates readme * Updates API version in new specs and examples * Added Approved and Backlog to Hunts Status enum (Azure#24552) * [Sentinel] [New Public API] Add swagger doc for dataConnectorDefinition API (Azure#24509) * add dataConnectorDefinition API doc * update examples * add pattern * update pattern * update pattern * update description * update description * small fix * small fix * small fix * small fix * update swagger document based on feedback from the SDK team (Azure#24555) * Fix dataConnectorDefinition (new API) (Azure#24759) * fix swagger doc * typo * fix int format * Fix pattern (Azure#24807) * remove pattern * add and fix - reuired parameter in the new validation * add and fix - reuired parameter in the new validation * fix pattren * fix pattren * Remove CloudError.cs file (Azure#24962) Remove CloudError.cs. Added by mistake in https://github.com/Azure/azure-rest-api-specs/pull/24807/files * Add pagination (Azure#24986) * add pagination --------- Co-authored-by: artafres <94412144+artafres@users.noreply.github.com> Co-authored-by: sagamzu <52034287+sagamzu@users.noreply.github.com>
…anagement group is not supported (Azure#24844)
This was referenced Aug 29, 2023
Closed
Closed
|
Hi @ragovada! For review efficiency consideration, when creating a new API version, it is required to place API specs of the base version in the first commit, and push new version updates into successive commits. You can use OpenAPIHub to initialize the PR for adding a new version. |
|
Please address or respond to feedback from the ARM API reviewer. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
18 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ARM (Control Plane) API Specification Update Pull Request
PR review workflow diagram
Please understand this diagram before proceeding. It explains how to get your PR approved & merged.
[1] ARM review queue (for merge queues, see [4])
The PRs are processed by time opened, ascending. Your PR may show up on 2nd or later page.
If you addressed Step 1 from the diagram and your PR is not showing up in the queue, ensure the label
ARMChangesRequestedis removed from your PR. This should cause the label
WaitForARMFeedbackto be added.[2] https://aka.ms/azsdk/support/specreview-channel
[3] List of SDK breaking changes approvers in pinned Teams announcement
[4] public repo merge queue, private repo merge queue (for ARM review queue, [1])
If you need further help with anything, see
Getting helpsection below.Purpose of this PR
What's the purpose of this PR? Check all that apply. This is mandatory!
Due diligence checklist
To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:
ARM resource provider contract and
REST guidelines (estimated time: 4 hours).
I understand this is required before I can proceed to Step 2, "ARM Review", for this PR.
Breaking changes review (Step 1)
you must follow the breaking changes process.
IMPORTANT This applies even if:
Such claims must be reviewed, and the process is the same.
ARM API changes review (Step 2)
ARMReviewlabel.Viewing API changes
For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the
Generated ApiViewcomment added to this PR. You can use ApiView to show API versions diff.Suppressing failures
If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
Swagger-Suppression-Process
to get approval.
Getting help
and https://aka.ms/ci-fix.